HomePhorge

Calendar: fix creation of ICS Files

Description

Calendar: fix creation of ICS Files

Summary:
It seems that, in an attempt to make ICS URI(s) editable, we broke the ability
to manually import ICS files. Whops.

The cause is, the URI needs to be put inside its dedicated import engine,
and not the general one.

Since the intention of T15137 was to be able to edit this field, we have done
that in the right way this time. So, you see the field, not just in creation mode.

Thanks to the kind aklapper for reporting.

Ref T15137
Closes T15619
Rollback 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b

Test Plan:

  • visit /calendar/import/ and:
  • create/edit an ICS File Import (now works again)
  • create/edit an ICS URI Import (still work)
  • try looking at an "ICS Import page" as author (URI still visible)
  • try looking at an "ICS Import page" without Edit permissions (URI still omitted correctly)

Reviewers: aklapper, O1 Blessed Committers, 20after4

Reviewed By: aklapper, O1 Blessed Committers, 20after4

Subscribers: 20after4, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15619, T15137

Differential Revision: https://we.phorge.it/D25448

Details

Provenance
Valerio BozzolanAuthored on Oct 25 2023, 10:07 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
Branches
Unknown
Tags
Unknown

Event Timeline