HomePhorge

Write fewer "applied" rows and clean up excess historical rows

Description

Write fewer "applied" rows and clean up excess historical rows

Summary:

  • Only write the <ruleID, phid> row if the rule is a one-time rule.
  • Delete all the rows for rules which aren't one-time.
NOTE: This is probably like several million rows for Facebook and could take a while.

Test Plan:
Added some one-time and every-time rules, ran them against objects, verified
only relevant rows were inserted.
Ran upgrade script against a database with one-time and every-time "ruleapplied"
rows, got the irrelevant rows removed.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1484

Details

Provenance
epriestleyAuthored on Jan 25 2012, 11:53 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPcb0bb8165d83: Add a Join / Leave button to Projects
Branches
Unknown
Tags
Unknown

Event Timeline