HomePhorge

Update all existing ProfileMenuItems for the more-structured API

Description

Update all existing ProfileMenuItems for the more-structured API

Summary:
Depends on D20357. Ref T13275. Now that there's a stronger layer between "stuff in the database" and "stuff on the screen", these subclasses all need to emit intermediate objects instead of raw, HTML-producing view objects.

This update is mostly mechanical.

Test Plan:

  • Viewed Home, Favorites, Portals, User Profiles, Project Profiles.
  • Clicked each item on each menu/profile type.
  • Added every (I think?) type of item to a menu and clicked them all.
  • Grepped for obsolete symbols (newNavigationMenuItems, willBuildNavigationItems).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13275

Differential Revision: https://secure.phabricator.com/D20358

Details

Provenance
epriestleyAuthored on Mar 31 2019, 12:07 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP950e9d085b48: In ProfileMenu, put more structure between "stored/configured items" and…
Branches
Loading...
Tags
Loading...

Event Timeline