Portals: Rename unused newNoMenuItemsView() to newNoContentView()
Summary:
Followup to rPf8b8d88
Rename uncalled newNoMenuItemsView() to newNoContentView() overwriting this method in the parent class, to fix showing more specific UI messages for empty portals.
Test Plan:
Code:
- Grep the code for non-existing newNoMenuItemsView
- Check code of parent class PhabricatorProfileMenuEngine
Workflows:
- Create an empty portal via http://phorge.localhost/portal/edit/form/default/, see correct (more specific) string "Use "Edit Menu" to add menu items to this portal." displayed
- Click "Edit Menu" to go to http://phorge.localhost/portal/view/1/configure/global/ of that Portal just created, on the right in "Add New Menu Item..." select "Divider" and click "Create Menu Item" button, go back to portal, see correct (more specific) string "None of the visible menu items in this portal can render any content." displayed
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Tags: #dashboards
Differential Revision: https://we.phorge.it/D25776