HomePhorge

Remove overbearing policy checks in Phame

Description

Remove overbearing policy checks in Phame

Summary:
Fixes T11584. This controller does unnecessary CAN_EDIT policy checks.

These checks are enforced by EditEngine, and you can make certain types of edits (including comments) even without full-blown edit permission.

Test Plan:

  • Commented as a user without edit permission.
  • Tried to edit as a user without edit permission, was rebuffed with a policy dialog.
  • Edited as a user with edit permission.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11584

Differential Revision: https://secure.phabricator.com/D16493

Details

Provenance
epriestleyAuthored on Sep 5 2016, 11:50 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4dc37bcee080: Ignore repository versions on inactive devices in "Repository Servers" panel in…
Branches
Unknown
Tags
Unknown

Event Timeline