HomePhorge

Support rendering arbitrary sections in the middle of a Harbormaster build log…

Description

Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work

Summary:
Depends on D19162. Ref T13088. When a user links to $1234, we need to render a default view of the log with a piece at the head, a piece at the end, and a piece in the middle.

We also need to figure out the offset for line 1234, or multiple offsets for "1234-2345".

Since the logic views/reads mostly anticipated this it isn't too much of a mess, although there are a couple of bugs this exposes with view specifications that use combinations of parameters which were previously impossible.

Test Plan: Viewed a large log with no line marker. Viewed $1. Viewed $end. Viewed $35-40, etc. Expanded context around logs.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13088

Differential Revision: https://secure.phabricator.com/D19163

Details

Provenance
epriestleyAuthored on Mar 1 2018, 6:43 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4466402c5a6d: Move Paste line range reading code into AphrontRequest
Branches
Unknown
Tags
Unknown

Event Timeline