HomePhorge

Fix rendering of comments deleted by editing

Description

Fix rendering of comments deleted by editing

Summary:
Fixes T4609. Steps are:

  • Make a comment.
  • Edit it.
  • Delete all the text.

We expect to see "This comment has been deleted." -- instead, things currently render goofy.

Root cause is that hasComment() means both "comment object exists" and "comment object is nonempty".

Test Plan: {F128862}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4609

Differential Revision: https://secure.phabricator.com/D8533

Details

Provenance
epriestleyAuthored on Mar 14 2014, 11:53 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP838f78128544: Add a robots.txt file to disallow /diffusion/
Branches
Unknown
Tags
Unknown

Event Timeline