HomePhorge

Prevent external connections from being mutated on held locks

Description

Prevent external connections from being mutated on held locks

Summary: Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan: Added a failing test, made it pass.

Maniphest Tasks: T13627

Differential Revision: https://secure.phabricator.com/D21584

Details

Provenance
epriestleyAuthored on Mar 2 2021, 12:53 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP15dbf6bdf0a5: When a GlobalLock with an external connection is released, don't return it to…
Branches
Unknown
Tags
Unknown

Event Timeline