HomePhorge

Record initial branch when recording commits

Description

Record initial branch when recording commits

Summary:
We have a race condition right now, where we may insert a commit without seenOnBranches. This means shouldAutocloseCommit will return false (since it's not on any autoclose branches) if the message parser runs fast enough, causing it to associate the commit but not close the revision. This happened for D2851.

Also prompt the user to repair broken repositories.

Test Plan: Ran discovery / repair. Ran discovery on new commits. Verified 'seenOnBranches' value. Deleted some data, verified "repair" error. Repaired repository.

Reviewers: jungejason, nh, vrana, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D2858

Details

Provenance
epriestleyAuthored on Jun 28 2012, 2:00 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP1e3cd8afa839: Improve notification list view
Branches
Unknown
Tags
Unknown

Event Timeline