HomePhorge

Don't barf on bad commit identifiers

Description

Don't barf on bad commit identifiers

Summary:
If someone provides an invalid svn rev number (like providing a git commit
hash instead) for a diffusion commit, we should ignore it like we ignore
other bad input to DiffusionCommitQuery, instead of barfing.

Test Plan:
put an invalid blame rev with rEsomehash (where E is an svn repo), and
differential loads.

Reviewers: epriestley, wez

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5389

Details

Provenance
Nick HarperAuthored on Mar 19 2013, 3:30 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP34e0f617a5b2: Adding trailing slash to 'Edit Mock' URI
Branches
Unknown
Tags
Unknown

Event Timeline