HomePhorge

Resolve deleted packages properly as having no mailable members

Description

Resolve deleted packages properly as having no mailable members

Summary:
Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.

Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.

Test Plan:

  • Added a package to a revision as a reviewer.
  • Destroyed the package.
  • Commented on the revision.
  • Processed the publishing worker with bin/worker execute.
  • Before: fatal after expanding the destroyed package.
  • After: clean publish.

Maniphest Tasks: T13648

Differential Revision: https://secure.phabricator.com/D21707

Details

Provenance
epriestleyAuthored on Jul 21 2021, 2:20 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4cffaa600bec: Rename "HarbormasterRestartException" to "HarbormasterMessageException"
Branches
Unknown
Tags
Unknown

Event Timeline