HomePhorge

Gracefully fail request if non existing callsign is passed to…

Description

Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing

Summary:
diffusion.getrecentcommitsbypath fails with 500 error when non existing callsign is passed:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getCommit() on null

Expected Behavior:
Return more graceful error notifying caller that such callsign/repository does not exist

Reproduction steps:
Open conduit: https://secure.phabricator.com/conduit/method/diffusion.getrecentcommitsbypath/
Enter:
callsign: "obviouslynotexisting"
path: "/random"
Click call method

Test Plan: after applying patch - call no longer fails with 500s

Reviewers: Pawka, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19558

Details

Provenance
Arturas MoskvinasAuthored on Aug 2 2018, 7:41 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4c09e88c9582: Add parsing for ssh options (-o) which are passed when using GIT v2 wire…
Branches
Unknown
Tags
Unknown

Event Timeline