HomePhorge

Don't put bad mailing list names in the CC list of a commit message

Description

Don't put bad mailing list names in the CC list of a commit message

Summary:
If we can't look up the name for a mailing list, don't put 'Unknown Mailing
List' in the commit message - it will confuse things later down the road.

Surely there is a better way of doing this than checking the name of the
handle for the mailing list.

Test Plan:
called differential.getcommitmessage on a revision that had an invalid mailing
list phid.

Reviewers: epriestley, schrockn, jungejason

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1910

Details

Provenance
Nick HarperAuthored on Mar 15 2012, 12:30 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPfa687e1773eb: Allow selecting author by double click in inline comment
Branches
Unknown
Tags
Unknown

Event Timeline