HomePhorge

Recover when cookies are disabled in Firefox and accessing localStorage throws

Description

Recover when cookies are disabled in Firefox and accessing localStorage throws

Summary:
Ref T13216. See PHI985. If you disable cookies in Firefox, accessing window.localStorage throws an exception. Currently, this pretty much kills all scripts on the page.

Instead, catch and ignore this, as though window.localStorage was not defined.

Test Plan:

  • Set Firefox to "no cookies".
  • Loaded any page while logged out.
  • Before: JS fatal early in the stack.
  • After: page loads and JS works.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19832

Details

Provenance
epriestleyAuthored on Nov 24 2018, 6:20 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP88189f723f05: Make a Feed query construction less clever/sneaky for new qsprintf() semantics
Branches
Loading...
Tags
Loading...

Event Timeline