HomePhorge

Don't exit from the Aphlict Server prematurely

Description

Don't exit from the Aphlict Server prematurely

Summary: By calling process.exit(1) we are forcing the Node.js process to exit prematurely. Specifically, the process is terminated before the error is written to the log file. This can be verified by inspecting the value of debug._logs[0]._writableState.writing immediately before the process is terminated.

Test Plan: Ran ./bin/aphlict debug without the ws module being installed. Verified that <<< UNCAUGHT EXCEPTION! >>> was echoed to the console as well as the log file. Also verified that the exit status was non-zero.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11426

Details

Provenance
Joshua SpenceAuthored on Jan 19 2015, 11:36 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP3bc54c2041be: Project revamp part 2: Edit
Branches
Unknown
Tags
Unknown

Event Timeline