HomePhorge

Bring Javelin into Phabricator via git submodule, not copy-and-paste

Description

Bring Javelin into Phabricator via git submodule, not copy-and-paste

Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.

Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.

Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test

Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows

Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223

Details

Provenance
epriestleyAuthored on May 3 2011, 3:11 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP846d625ed0eb: [differential] gmail-compatible emails
Branches
Unknown
Tags
Unknown

Event Timeline