HomePhorge

Adding support for 'adds' and 'removes' in diff content.

Description

Adding support for 'adds' and 'removes' in diff content.

Summary:
Does what it says on the label. We already had 'Any changed file content', now we have 'Any added file content' and 'Any removed file content'.

  • There is a bit of copied/pasted code here: I'm open to suggestions on how to refactor it so it's less redundant.
  • The wording seems a little awkward, and as @epriestley mentioned in T3829, moved code will be detected less than ideally.

Test Plan: Created Herald Rules, verified via dry run that they were triggered in appropriate situations.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3829

Differential Revision: https://secure.phabricator.com/D7214

Details

Provenance
Neal PooleAuthored on Oct 4 2013, 6:37 AM
epriestleyCommitted on Oct 4 2013, 6:37 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPa6c4117ec434: Fix controller-level access rules
Branches
Unknown
Tags
Unknown

Event Timeline