HomePhorge

Clean up virtual "_ft_rank" column for query construction of Ferret objects

Description

Clean up virtual "_ft_rank" column for query construction of Ferret objects

Summary:
Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan:
Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12974

Differential Revision: https://secure.phabricator.com/D18728

Details

Provenance
epriestleyAuthored on Oct 23 2017, 3:04 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP683df399e7f4: Simplify UNION/ORDER query construction in DifferentialRevisionQuery
Branches
Unknown
Tags
Unknown

Event Timeline