HomePhorge

Make TabGroups a standalone UI element

Description

Make TabGroups a standalone UI element

Summary:
Ref T10628. Currently, tabs are part of ObjectBoxes. However, the code is a bit of a mess and I want to use them in some other contexts, notably the "prose diff" dialog to show "old raw, new raw, diff".

Pull them out, and update Files to use the new stuff. My plan is:

  • Update all callsites to this stuff.
  • Remove the builtin-in ObjectBox integration to simplify ObjectBox a bit.
  • Move forward with T10628.

This is pretty straightforward. A couple of the sigils are a little weird, but I'll update the JS later. For now, the same JS can drive both old and new tabs.

Test Plan: Viewed files, everything was unchanged.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16205

Details

Provenance
epriestleyAuthored on Jun 30 2016, 3:57 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP01862b8f23ac: Detect the MIME type of large files by examining the first chunk
Branches
Loading...
Tags
Loading...

Event Timeline