HomePhorge

When administrators revoke SSH keys, don't include a "security warning" in the…

Description

When administrators revoke SSH keys, don't include a "security warning" in the mail

Summary:
Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan:

  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13043

Differential Revision: https://secure.phabricator.com/D18907

Details

Provenance
epriestleyAuthored on Jan 21 2018, 5:55 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP026ec11b9d6b: Add a rate limit for guessing old passwords when changing passwords
Branches
Unknown
Tags
Unknown

Event Timeline