HomePhorge

Fix "Any Owner" and "No Owners" searches in Maniphest

Description

Fix "Any Owner" and "No Owners" searches in Maniphest

Summary:
See https://discourse.phabricator-community.org/t/maniphest-home-page-crash-after-d19417/1445/3. These special-token-only searches currently end up populating an empty ownerPHIDs, which fatals after the stricter check in D19417.

Make the fatal on withConstraint(array()) explicit and only set the PHID constraint if we have some PHIDs left.

Test Plan: Searched for "No Owner", "Any Owner", an actual owner, "No Owner + actual user".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19440

Details

Provenance
epriestleyAuthored on May 9 2018, 12:58 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd280b24239fc: Fix "arc paste" to stop creating pastes with an empty string ("") as the…
Branches
Loading...
Tags
Loading...

Event Timeline