HomePhorge

Use predictable filenames when downloading raw diffs from a revision

Description

Use predictable filenames when downloading raw diffs from a revision

Summary:
To prevent spammers from abusing this feature on a public server, do not include query parameters in the generated filenames. See https://github.com/mozilla-conduit/phabricator/commit/d8bb7d91b7d219902afed1ae7a8ae5e33862a842.

Ref T15665.

Test Plan: Download raw diff from a revision and check filename in URL.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15665

Differential Revision: https://we.phorge.it/D25478

Signed-off-by: Zero King <l2dy@icloud.com>

Details

Provenance
David LawrenceAuthored on Aug 29 2023, 11:25 AM
Zero KingCommitted on Mar 6 2024, 8:03 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP179f866deb74: Make lipsum project generator also fill in project description
Branches
Loading...
Tags
Loading...

Event Timeline