HomePhorge
Diffusion Phorge 0d070c91dc8d

Fix Aphlict logging
0d070c91dc8d
Actions

Description

Fix Aphlict logging

Summary:
Yeahhhhhhhh....

  • Open a "stream", not a "steam".
  • Make error easier for users to understand.
  • Write to the log in debug mode so the issue is more apparent.

Test Plan:

  • Started server with bad permissions, got usable error message.
  • Started server with good permissions, got logfile.

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11339

Details

Provenance
epriestleyAuthored on Jan 12 2015, 8:16 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP790d250967cc: Move ActionList mobile links to better location
Branches
Loading...
Tags
Loading...

Event Timeline

Changes (3)

PathSize
src/
applications/
aphlict/
management/
support/
aphlict/
server/
lib/

rP0d070c91dc8d

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

<?php <?php
/** /**
* @group conpherence * @group conpherence
*/ */
final class ConpherenceThreadQuery final class ConpherenceThreadQuery
extends PhabricatorCursorPagedPolicyAwareQuery { extends PhabricatorCursorPagedPolicyAwareQuery {
private $phids; private $phids;
private $ids; private $ids;
private $needWidgetData; private $needWidgetData;
private $needHeaderPics; private $needHeaderPics;
private $needOrigPics; private $needOrigPics;
private $needAllTransactions; private $needAllTransactions;
private $beforeMessageID;
public function needOrigPics($need_orig_pics) { public function needOrigPics($need_orig_pics) {
$this->needOrigPics = $need_orig_pics; $this->needOrigPics = $need_orig_pics;
return $this; return $this;
} }
public function needHeaderPics($need_header_pics) { public function needHeaderPics($need_header_pics) {
$this->needHeaderPics = $need_header_pics; $this->needHeaderPics = $need_header_pics;
Show All 15 Lines public function withIDs(array $ids) {
return $this; return $this;
} }
public function withPHIDs(array $phids) { public function withPHIDs(array $phids) {
$this->phids = $phids; $this->phids = $phids;
return $this; return $this;
} }
// TODO: This is pretty hacky!
public function setBeforeMessageID($id) {
$this->beforeMessageID = $id;
return $this;
}
protected function loadPage() { protected function loadPage() {
$table = new ConpherenceThread(); $table = new ConpherenceThread();
$conn_r = $table->establishConnection('r'); $conn_r = $table->establishConnection('r');
$data = queryfx_all( $data = queryfx_all(
$conn_r, $conn_r,
'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q', 'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q',
$table->getTableName(), $table->getTableName(),
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines private function loadParticipants(array $conpherences) {
return $this; return $this;
} }
private function loadTransactionsAndHandles(array $conpherences) { private function loadTransactionsAndHandles(array $conpherences) {
$transactions = id(new ConpherenceTransactionQuery()) $transactions = id(new ConpherenceTransactionQuery())
->setViewer($this->getViewer()) ->setViewer($this->getViewer())
->withObjectPHIDs(array_keys($conpherences)) ->withObjectPHIDs(array_keys($conpherences))
->needHandles(true) ->needHandles(true)
->setBeforeID($this->beforeMessageID)
->execute(); ->execute();
$transactions = mgroup($transactions, 'getObjectPHID'); $transactions = mgroup($transactions, 'getObjectPHID');
foreach ($conpherences as $phid => $conpherence) { foreach ($conpherences as $phid => $conpherence) {
$current_transactions = $transactions[$phid]; $current_transactions = $transactions[$phid];
$handles = array(); $handles = array();
foreach ($current_transactions as $transaction) { foreach ($current_transactions as $transaction) {
$handles += $transaction->getHandles(); $handles += $transaction->getHandles();
} }
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

support/aphlict/server/aphlict_server.js

<?php <?php
/** /**
* @group conpherence * @group conpherence
*/ */
final class ConpherenceThreadQuery final class ConpherenceThreadQuery
extends PhabricatorCursorPagedPolicyAwareQuery { extends PhabricatorCursorPagedPolicyAwareQuery {
private $phids; private $phids;
private $ids; private $ids;
private $needWidgetData; private $needWidgetData;
private $needHeaderPics; private $needHeaderPics;
private $needOrigPics; private $needOrigPics;
private $needAllTransactions; private $needAllTransactions;
private $beforeMessageID;
public function needOrigPics($need_orig_pics) { public function needOrigPics($need_orig_pics) {
$this->needOrigPics = $need_orig_pics; $this->needOrigPics = $need_orig_pics;
return $this; return $this;
} }
public function needHeaderPics($need_header_pics) { public function needHeaderPics($need_header_pics) {
$this->needHeaderPics = $need_header_pics; $this->needHeaderPics = $need_header_pics;
Show All 15 Lines public function withIDs(array $ids) {
return $this; return $this;
} }
public function withPHIDs(array $phids) { public function withPHIDs(array $phids) {
$this->phids = $phids; $this->phids = $phids;
return $this; return $this;
} }
// TODO: This is pretty hacky!
public function setBeforeMessageID($id) {
$this->beforeMessageID = $id;
return $this;
}
protected function loadPage() { protected function loadPage() {
$table = new ConpherenceThread(); $table = new ConpherenceThread();
$conn_r = $table->establishConnection('r'); $conn_r = $table->establishConnection('r');
$data = queryfx_all( $data = queryfx_all(
$conn_r, $conn_r,
'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q', 'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q',
$table->getTableName(), $table->getTableName(),
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines private function loadParticipants(array $conpherences) {
return $this; return $this;
} }
private function loadTransactionsAndHandles(array $conpherences) { private function loadTransactionsAndHandles(array $conpherences) {
$transactions = id(new ConpherenceTransactionQuery()) $transactions = id(new ConpherenceTransactionQuery())
->setViewer($this->getViewer()) ->setViewer($this->getViewer())
->withObjectPHIDs(array_keys($conpherences)) ->withObjectPHIDs(array_keys($conpherences))
->needHandles(true) ->needHandles(true)
->setBeforeID($this->beforeMessageID)
->execute(); ->execute();
$transactions = mgroup($transactions, 'getObjectPHID'); $transactions = mgroup($transactions, 'getObjectPHID');
foreach ($conpherences as $phid => $conpherence) { foreach ($conpherences as $phid => $conpherence) {
$current_transactions = $transactions[$phid]; $current_transactions = $transactions[$phid];
$handles = array(); $handles = array();
foreach ($current_transactions as $transaction) { foreach ($current_transactions as $transaction) {
$handles += $transaction->getHandles(); $handles += $transaction->getHandles();
} }
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

support/aphlict/server/lib/AphlictLog.js

<?php <?php
/** /**
* @group conpherence * @group conpherence
*/ */
final class ConpherenceThreadQuery final class ConpherenceThreadQuery
extends PhabricatorCursorPagedPolicyAwareQuery { extends PhabricatorCursorPagedPolicyAwareQuery {
private $phids; private $phids;
private $ids; private $ids;
private $needWidgetData; private $needWidgetData;
private $needHeaderPics; private $needHeaderPics;
private $needOrigPics; private $needOrigPics;
private $needAllTransactions; private $needAllTransactions;
private $beforeMessageID;
public function needOrigPics($need_orig_pics) { public function needOrigPics($need_orig_pics) {
$this->needOrigPics = $need_orig_pics; $this->needOrigPics = $need_orig_pics;
return $this; return $this;
} }
public function needHeaderPics($need_header_pics) { public function needHeaderPics($need_header_pics) {
$this->needHeaderPics = $need_header_pics; $this->needHeaderPics = $need_header_pics;
Show All 15 Lines public function withIDs(array $ids) {
return $this; return $this;
} }
public function withPHIDs(array $phids) { public function withPHIDs(array $phids) {
$this->phids = $phids; $this->phids = $phids;
return $this; return $this;
} }
// TODO: This is pretty hacky!
public function setBeforeMessageID($id) {
$this->beforeMessageID = $id;
return $this;
}
protected function loadPage() { protected function loadPage() {
$table = new ConpherenceThread(); $table = new ConpherenceThread();
$conn_r = $table->establishConnection('r'); $conn_r = $table->establishConnection('r');
$data = queryfx_all( $data = queryfx_all(
$conn_r, $conn_r,
'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q', 'SELECT conpherence_thread.* FROM %T conpherence_thread %Q %Q %Q',
$table->getTableName(), $table->getTableName(),
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines private function loadParticipants(array $conpherences) {
return $this; return $this;
} }
private function loadTransactionsAndHandles(array $conpherences) { private function loadTransactionsAndHandles(array $conpherences) {
$transactions = id(new ConpherenceTransactionQuery()) $transactions = id(new ConpherenceTransactionQuery())
->setViewer($this->getViewer()) ->setViewer($this->getViewer())
->withObjectPHIDs(array_keys($conpherences)) ->withObjectPHIDs(array_keys($conpherences))
->needHandles(true) ->needHandles(true)
->setBeforeID($this->beforeMessageID)
->execute(); ->execute();
$transactions = mgroup($transactions, 'getObjectPHID'); $transactions = mgroup($transactions, 'getObjectPHID');
foreach ($conpherences as $phid => $conpherence) { foreach ($conpherences as $phid => $conpherence) {
$current_transactions = $transactions[$phid]; $current_transactions = $transactions[$phid];
$handles = array(); $handles = array();
foreach ($current_transactions as $transaction) { foreach ($current_transactions as $transaction) {
$handles += $transaction->getHandles(); $handles += $transaction->getHandles();
} }
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines