HomePhorge

Remove redundant administrator requirement from application edit policy page

Description

Remove redundant administrator requirement from application edit policy page

Summary:
Fixes T7485. Before applications had proper policies, we gated access by requiring the viewer be an administrator.

This is now redundant (CAN_EDIT on applications has the same effect, and performs the same check), and may some day be wrong (we might let administrators configure a different policy to control who can configure applications). Today, it gets the policy dialog wrong.

Test Plan:
Clicked "Edit Policies" as a non-administrator, was unable to, got nice error:

{F346598}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7485

Differential Revision: https://secure.phabricator.com/D12125

Details

Provenance
epriestleyAuthored on Mar 23 2015, 9:10 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc7dc59f9c403: Don't call flush() when emitting responses
Branches
Unknown
Tags
Unknown

Event Timeline