HomePhorge

Fix an error when users receive notifications about objects they can no longer…

Description

Fix an error when users receive notifications about objects they can no longer see

Summary:
Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see.

Move the story-loading piece to "willFilterPage()" to make our way thorugh this.

Test Plan:

  • Made FeedStory return nothing to simulate invisible notifications, loaded page.
    • Before: index access fatal.
    • After: clean "no notifications".
  • Loaded notifications normally, saw normal notifications.

Maniphest Tasks: T13623

Differential Revision: https://secure.phabricator.com/D21603

Details

Provenance
epriestleyAuthored on Mar 11 2021, 10:31 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search
Branches
Unknown
Tags
Unknown

Event Timeline