HomePhorge

Improve implementation of ManiphestTaskQuery

Description

Improve implementation of ManiphestTaskQuery

Summary:
Currently, we have a single projectPHIDs field, and a separate flag which makes it act like AND or OR.

This is silly. Make two separate methods for setting AND vs OR projects. This also simplifies the implmentation.

This doesn't change the UI or any behavior (yet), it just makes the API more usable.

Test Plan: Loaded homepage, "All Projects" task view, verified queries made sense and returned correct results. Grepped for changed method name.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1610

Differential Revision: https://secure.phabricator.com/D3630

Details

Provenance
epriestleyAuthored on Oct 4 2012, 3:30 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP689c98c47c33: Update database.schema doc to include how to upgrade the schema
Branches
Unknown
Tags
Unknown

Event Timeline