HomePhorge

Add a relation table for Revisions to local commit hashes

Description

Add a relation table for Revisions to local commit hashes

Summary:
This allows us to performantly query for diffs related to a given local hash.
Immediate applications are:

  • Commit detection in Mercurial and Git-Immutable workflows.
  • Some async unit test stuff @mgummelt was doing.

Test Plan:
Diffed locally under SVN/Git/hg, checked the table, got sensible output.

mysql> select * from differential_revisionhash;
+------------+------+------------------------------------------+
| revisionID | type | hash                                     |
+------------+------+------------------------------------------+
|         40 | gtcm | 8c6fb2f95598a50f7aac64a5f4cc6c12b5db42f5 |
|         40 | gttr | 54710e361a465f4ff39565a93b2a221b6e7dd07c |
|         41 | hgcm | c29cb69aec14                             |
|         41 | hgcm | e7309be4eabb                             |
|         41 | hgcm | 4e885caeff60                             |
|         41 | hgcm | 213ee1cd30ea                             |
|         41 | hgcm | b4050fb3490f                             |
|         41 | hgcm | 72a76bd7ffa2                             |
|         41 | hgcm | 06c2687e63fb                             |
|         41 | hgcm | 2b464bde6b48                             |
+------------+------+------------------------------------------+
10 rows in set (0.00 sec)
NOTE: Mercurial hashes are short-form but I'll shoot out a separate Arcanist diff to fix this.

Reviewers: Makinde, fratrik, mgummelt, jungejason, nh, tuomaspelkonen, aran

Reviewed By: Makinde

CC: aran, Makinde

Differential Revision: 961

Details

Provenance
epriestleyAuthored on Sep 26 2011, 2:20 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd0b6602e294d: Add an option to switch tokenizers to use "ondemand" instead of "preloaded"
Branches
Unknown
Tags
Unknown

Event Timeline